This repository has been archived by the owner on Mar 25, 2021. It is now read-only.
[bugfix][enhancement][rule-change] Get rid of check-type option in whitespace rule
#4110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As I mentioned in #4109, if theres not an issue for this it would be great if you could make one so we can discuss all these whitespace changes together. |
|
Closing for housekeeping, see #4109 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Get rid of check-type option of
whitespacerule because of its inconsistency: basing on code, rule's walker determines whether a previous token is a colon and then checks a need for whitespace. The problem is that the colon is used not only for type definition, but also, for example, for conditional operator.I propose to use separate
typedef-whitespacerule instead.